add security challenge page #322
Merged
+182
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abbycabs
requested review from
AndreaGriffiths11,
LadyKerr,
cassidoo and
karasowles
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new Security Challenge page to the Maintainer Month site, including navigation support and a shield icon.
- Introduces
SecurityChallengepage with course listings and markdown-driven content - Adds
IconShieldcomponent and hooks it into the header navigation - Updates routes and translation keys for the new page
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| public/icons/shield.js | New shield SVG icon component |
| pages/security-challenge.js | New Security Challenge page with markdown content |
| content/commons.json | Added navigation label for security challenge |
| components/header/Header.jsx | Added Shield icon and link for Security Challenge |
| common/routes.js | Defined SECURITY_CHALLENGE route |
Comments suppressed due to low confidence (2)
pages/security-challenge.js:48
- [nitpick] The variable
content_enduses snake_case. Rename it tocontentEndto follow JavaScript camelCase conventions.
const content_end = marked(`
content/commons.json:64
- [nitpick] The navigation label
"Challenge"is quite generic. Consider renaming it to"Security Challenge"for clarity in the menu.
"navigation:security-challenge": "Challenge",
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.